Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Maximised window has small gap between tabs and top of screen #1105

Closed
matt1 opened this issue Aug 2, 2018 · 0 comments · May be fixed by #1109
Closed

Maximised window has small gap between tabs and top of screen #1105

matt1 opened this issue Aug 2, 2018 · 0 comments · May be fixed by #1109

Comments

@matt1
Copy link
Contributor

matt1 commented Aug 2, 2018

Operation System: Windows 10
Beaker version: Version: 0.8.0-prerelease.7 Electron: 2.0.5 - Chromium: 61.0.3163.100 - Node: 8.9.3

When the window is maximised on Windows, there is a small space between the top of the tabs and the top of the screen. This makes it awkward to select the tabs since you need to accurately move the mouse to make sure you hit the tab to avoid moving "above" the tabs - in most other tabbed browsers the tabs extend to the very top of the screen so that you cannot "overrun" the tab area with the mouse.

This appears to be the culprit:

// make room for resizing on the top

There seems to be a fullscreen class for what I guess is Mac fullscreen use - if there was a similar class for maximised then you'd not need the resize border space?

E.g. somewhere here you could do something similar for the 'maximize' and 'unmaximize' (sic) events as has already been done for the fullscreen:

function onWindowEvent (event, type) {

@matt1 matt1 changed the title Maximised window does has small border between tabs and top of screen Maximised window has small gap between tabs and top of screen Aug 2, 2018
@pfrazee pfrazee closed this as completed May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants