Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable relayer to use ESTIMATION_ADDRESS (0x1) when estimating relays from optimism #1945

Open
fredo opened this issue Jun 15, 2023 · 1 comment
Labels
contracts 🧾 needs discussion Unclear issue description and needs further discussion before refinement can be done relayer

Comments

@fredo
Copy link
Contributor

fredo commented Jun 15, 2023

We cannot use the 0x1 Estimation address hack by Optimism because we use the tx.origin in ArbitrumL1Messenger as authentithicaiton for payment of the submission fee. 0x1 during estimation has a deposit of 0 -> revert.

This imposes the problem that the gas estimation cannot be used and the agent needs to try and retry blindly until relaying a message works. This could drain the agent’s funds.

Options

We can get back to the OP hack once we either don’t use the
tx.origin in the ArbitrumL1Messenger anymore or we are able to deposit on behalf of “0x1” (hack for the hack)

Edit: We could actually hardcode a deposit of the 0x1 address. There is no need to actually deposit anything.

@fredo fredo added contracts 🧾 relayer needs discussion Unclear issue description and needs further discussion before refinement can be done labels Jun 15, 2023
@fredo
Copy link
Contributor Author

fredo commented Jul 4, 2023

partially duplicate of #1589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts 🧾 needs discussion Unclear issue description and needs further discussion before refinement can be done relayer
Projects
None yet
Development

No branches or pull requests

1 participant