Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert all times to timestamps #16

Open
beanumber opened this issue Aug 27, 2015 · 10 comments
Open

convert all times to timestamps #16

beanumber opened this issue Aug 27, 2015 · 10 comments

Comments

@beanumber
Copy link
Owner

This would be "cleaner". Would it improve performance? Should they be indexed?

@beanumber
Copy link
Owner Author

If so, this would help to clarify #5

@beanumber
Copy link
Owner Author

Note that the original data contains FlightDate.

@nicholasjhorton
Copy link
Collaborator

Does this affect my installation? Does it impact the pending request at Amherst? If so, can you please reply to my earlier note to Aaron Coburn?

Thanks in advance,

Nick

On Aug 31, 2015, at 2:28 PM, Ben Baumer notifications@github.com wrote:

Note that the original data contains FlightDate.


Reply to this email directly or view it on GitHub.

@beanumber
Copy link
Owner Author

This doesn't (yet), but the addition of cancelled does. The good news is I fixed the create bug #17.

@beanumber
Copy link
Owner Author

See (tidyverse#11)

@beanumber
Copy link
Owner Author

Note that hadley has made this change to nycflights13

@beanumber
Copy link
Owner Author

This is done.

@beanumber
Copy link
Owner Author

So now I am thinking that we do this differently. I am thinking:

  • store dep_time and arr_time as POSIXct timestamps
  • store dep_delay and arr_delay as integers
  • drop year, month, day, sched_dep_time, sched_arr_time, hour, minute, and time_hour

That might actually reduce the file size quite a bit. It would break compatibility with @hadley 's nycflights13, but nycflights13 would still be recoverable from airlines -- it would just require a little extra wrangling.

@beanumber beanumber reopened this May 12, 2016
@beanumber
Copy link
Owner Author

@nicholasjhorton what do you think of this idea?

@nicholasjhorton
Copy link
Collaborator

Sounds reasonable to me.

Nick

On Jun 9, 2016, at 9:40 AM, Ben Baumer notifications@github.com wrote:

@nicholasjhorton what do you think of this idea?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Nicholas Horton
Professor of Statistics
Department of Mathematics and Statistics, Amherst College
Box 2239, 31 Quadrangle Dr
Amherst, MA 01002-5000
https://www.amherst.edu/people/facstaff/nhorton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants