Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming of functions #16

Closed
nicholasjhorton opened this issue Jan 21, 2016 · 1 comment
Closed

naming of functions #16

nicholasjhorton opened this issue Jan 21, 2016 · 1 comment

Comments

@nicholasjhorton
Copy link

If I'm understanding things correctly there are:

etl()
etl_create()
etl_update()
etl_extract(), and
etl_cleanup()

functions in the etl framework. Might it make sense to change etl() to etl_init() and etl_create() to etl_populate()? The others feel more self explanatory (but "etl()" by itself doesn't make sense).

@beanumber
Copy link
Owner

There is also etl_transform and etl_load.

etl is the constructor. @hadley likes constructors, so I am inclined to keep that.

The four main functions in the pipeline are:

etl_extract()
etl_transform()
etl_load()
etl_cleanup()

The two functions etl_create and etl_update are just wrappers to that pipeline. @cpsievert also favors junking the wrapping functions. I'm happy to consider re-naming either, but etl_populate sounds more like a replacement for etl_load than etl_create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants