-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orders GetServiceStatus #100
Comments
I've encountered this when needlessly specifying the
MWS seems to do fine with the extraneous variable so we don't stop the request, but just notify the user they may not need to send it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When calling GetServiceStatus for the Orders API I get "Cannot read property 'list' of undefined" errors.
Looking through the code it would appear that /lib/request.js is checking for param.list when there isn't a param object.
I implemented a quick fix to check if param exists before trying to check if it has properties and executing this block of code. "if (param){" . This fixes the immediate error but I haven't had time to check if this is quite the right place to do this. Maybe the /lib/sections should define an empty params on GetServiceStatus ?
Here is the complete change, line 152 in /lib/request.js
Quite happy to do a pull request if this is ok
The text was updated successfully, but these errors were encountered: