Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Jaeger/Opentrace to Open-telemetry clients/SDKs #434

Closed
rbroggi opened this issue Nov 1, 2021 · 7 comments · Fixed by #685
Closed

Migrate from Jaeger/Opentrace to Open-telemetry clients/SDKs #434

rbroggi opened this issue Nov 1, 2021 · 7 comments · Fixed by #685
Milestone

Comments

@rbroggi
Copy link

rbroggi commented Nov 1, 2021

Is your feature request related to a problem? Please describe

As in this official communication Jaeger clients and opentrace libraries deprecation have been announced for December. OpenTelemetry is the recommended alternative. I'm opening this issue so we can centralize discussions and efforts to make this migration in patron while minimizing side effects to users.

Describe the solution

We should replace the following dependencies (can be found in go.mod):

github.com/uber/jaeger-client-go
github.com/uber/jaeger-lib
github.com/opentracing/opentracing-go

in favor of:

go.opentelemetry.io/otel/sdk
go.opentelemetry.io/otel
go.opentelemetry.io/otel/trace
go.opentelemetry.io/otel/exporters/jaeger
go.opentelemetry.io/otel/exporters/prometheus

Additional context

Useful links:

@mantzas
Copy link

mantzas commented Nov 1, 2021

@rbroggi We did wait for OpenTelemetry to become production grade in all (tracing, metric and logs) and make an overhaul.
Metrics are still alpha and logs seemed to be frozen.
Will this be seamless of more like a breaking change?

@rbroggi
Copy link
Author

rbroggi commented Nov 1, 2021

@rbroggi We did wait for OpenTelemetry to become production grade in all (tracing, metric and logs) and make an overhaul. Metrics are still alpha and logs seemed to be frozen. Will this be seamless of more like a breaking change?

I'm still in the early stage of evaluating the consequences for patron. I'm not sure if it will be a breaking change yet.
Metrics are indeed still in alpha, and probably we should be considering to scope this issue to tracing only.

Whichever direction we choose to go, I think we can use this issue to keep track of our choices and collect inputs, opinions, and experiments to make an informed decision going forward.

I don't think we need to rush, but the deprecation warning of jaeger-client (and the recommendation from the jaeger team to open telemetry) is something worth acknowledging.

@mantzas
Copy link

mantzas commented Nov 1, 2021

I did not see that at all!
That makes it a good candidate for moving to it!
Let's 🤞🏼 that nothing breaks.

@mantzas mantzas added the maintenance Maintenance work label Nov 1, 2021
@mantzas
Copy link

mantzas commented Nov 1, 2021

@rbroggi for completeness sake can you also add a link for the deprecation notice?

@rbroggi
Copy link
Author

rbroggi commented Nov 1, 2021

add a link for the deprecation notice?

It is the first link above: this official communication in:

As in this official communication Jaeger clients and opentrace libraries deprecation

@rbroggi
Copy link
Author

rbroggi commented Nov 1, 2021

As I'm trying to update the official set of examples in Jaeger, I will try to update patron as an experiment after that.

We could consider releasing a beta patron version and use in some services for a while before massive adoption.

@mantzas
Copy link

mantzas commented Nov 1, 2021

The change is very deeply integrated in all component clients etc. It will be a bigger task i am afraid (assuming it will not be a seamless upgrade).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants