-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for the 'Process image using a BioImage.IO model' Galaxy tool #26
Comments
Can @rabuono be added as collaborator to the repository where the issue resides? Thanks @beatrizserrano! |
@B0r1sD Can you please add an example of the input for which the tools fails? |
@rabuono did all the testing, so he knows best. |
Link to original PR of the tool: bgruening/galaxytools#1391 |
Added @rabuono! 🎉 |
Challenge 1: Picking a model from the data library by choosing a "remote" file at "ML Models/bioimaging-models" and choosing a 2D compatible model like The same procedure, but choosing a 3D model to run on a 3D dataset (2 z slices) does not work. Challenge 2: |
Still looking into Challenge 1, but we figured out Challenge 2:
You need to download the Torchscript format file from the BMZ. This will give you a ZIP file, that you need to unzip. Inside the zip, you will find a .pt file. Galaxy will automatically recognize this is a ZIP file (no need to rename it or anything). This is the file that you need to feed into the tool. It would be nice if this information could be added to the help text of the model input field of the tool! |
Regarding Challenge 1, I managed to reproduce the error with a test case in bgruening/galaxytools#1544 |
Regarding challenge 1, Indeed, if I try 2D models and I provide my own 2d image (a simple 1024,512,1,1 8-bit tiff), it works. Meaning that I can run the 2D models available on my own dataset and not only on the example dataset that the tool was made with. |
Regarding challenge 1, If I try a same 3D image (256,256,2,1 8bit tiff) with the following 3D models available in "remote" file at "ML Models/bioimaging-models", it does not work.
A few of the errors seem to be similar to |
One issue here might be that most models expect the first input tensor dimension to be a batch dimension... to address this it would be cool to inform the user of the required input axes and let them annotate the image dimensions accordingly... (or verify a guess). Btw, |
Short update on challenge 1:
If I download the torchscript and upload the .pt to Galaxy, it still fails. |
Sorry for the accidental issue closing. |
It would be very helpful if you could recreate all these failed cases as tests (or maybe not all, but a representative subset), similar to what I have done here: bgruening/galaxytools#1544 This will greatly facilitate fixing the issue in the future. |
The wrapper for Process image using a BioImage.IO model should receive an update as it fails most of the time when actively trying to get it to run example models (@rabuono).
The text was updated successfully, but these errors were encountered: