windows 8 error: path.js:204 throw new TypeError('Arguments to path.join must be strings');

[devdude13]

Found this on js-beautify 1.4

Root cause: in js-beautify\js\lib\cli.js:135:22 process.env.HOME is undefined

Work around is to define the environment variable like so in powershell before invoking js-beautify
$env:HOME="c:\users\johndoe"

Note: I am operating under all defaults. I haven't customized the install in any way and it looks like js-beautify expects an environment variable HOME to be defined which is (sometimes) not the case

Full error

PS C:\Users\johndoe\code\html\bootstrapPlayground> js-beautify --file "C:\Users\johndoe\code\html\test.html"

path.js:204
throw new TypeError('Arguments to path.join must be strings');
^
TypeError: Arguments to path.join must be strings
at f (path.js:204:15)
at Object.filter (native)
at Object.exports.join (path.js:209:40)
at Object.exports.interpret (C:\Users\johndoe\AppData\Roaming\npm\node_modules\js-beautify\js\lib\cli.js:135:22)
at Object. (C:\Users\johndoe\AppData\Roaming\npm\node_modules\js-beautify\js\bin\js-beautify.js:4:5)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)

[bitwiseman]

Perfect bug report, thanks!

We don't cover windows specifically in our test matrix, so understandable.

[fprijate]

Hi

The reason is that cl.js uses HOME environment variable.

Solutions:

1. run it in MSYS console.

or

2 SET HOME=XX

or preferably

3 change line 135 in cl.js to
cc.find(path.join(process.env.HOME || '"", ".jsbeautifyrc")),

regards
Franček

[evocateur]

Seems like we should be using process.env.USERPROFILE instead of the empty string, as indicated in this stack overflow answer. With the empty string alternate, on Windows the search for .jsbeautifyrc in the current directory will happen twice.

[fprijate]

Yes, it's better solution.
Code should be:
cc.find(path.join(process.env.HOME || process.env.USERPROFILE || '"", ".jsbeautifyrc")),
Anyhow || "" must be in expression, because there is possibility that both $HOME and $USERPROFILE
are not defined.

regards

[fprijate]

One solution is to set default $HOME for every
process.platform

[bitwiseman]

It looks like this was at least partially addressed by #304, yes?

[evocateur]

It is mitigated, yes, but the actual functionality provided by that line will be lost to Windows users (utilizing a config file in the user's home directory).

[einars]

So, a pull request from somebody with a windows box who can add the userprofile check and verify that rc in homedir is working, is welcome.