Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jshint cleanup and make require.js optimizable #302

Conversation

eleith
Copy link

@eleith eleith commented Jul 3, 2013

some lint cleanup stuff to tame the jshint beast

but mostly, this patch is about require.js

when you passin the require module through the define function, i'm unable to get r.js (require's node module for optimizing scripts) to properly optimize beautify-html. my guess is that it does not read that beautify-html has two dependencies.

however, when using define's first parameter option which is to pass an array of dependency, r.js properly picks up the dependencies and bundles them in the optimization process.

i'm using this over at coursera and with these modifications it works great in our build process.

@einars
Copy link
Contributor

einars commented Jul 3, 2013

Thanks! I split the commit into two — a separate commit for a cleanup and a separate commit for the require-js-ification.

@einars einars closed this Jul 3, 2013
@einars
Copy link
Contributor

einars commented Jul 3, 2013

513dfdb 4d9c107

@bitwiseman
Copy link
Member

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants