jshint cleanup and make require.js optimizable #302
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some lint cleanup stuff to tame the jshint beast
but mostly, this patch is about require.js
when you passin the require module through the define function, i'm unable to get r.js (require's node module for optimizing scripts) to properly optimize beautify-html. my guess is that it does not read that beautify-html has two dependencies.
however, when using define's first parameter option which is to pass an array of dependency, r.js properly picks up the dependencies and bundles them in the optimization process.
i'm using this over at coursera and with these modifications it works great in our build process.