Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with combination of CoolURI, Multidomain and SSL/HTTPS #58

Open
JoJoAction opened this issue Oct 1, 2016 · 2 comments
Open

Issue with combination of CoolURI, Multidomain and SSL/HTTPS #58

JoJoAction opened this issue Oct 1, 2016 · 2 comments

Comments

@JoJoAction
Copy link

JoJoAction commented Oct 1, 2016 •
edited
Loading

In the latest stable release (1.1.2) there is a problem when it comes to the combination of CoolURI, Multidomain and SSL/HTTPS. In "CoolUri.php", lines 322 and 471, the URL is preceeded statically by "http://", instead of checking if "https://" would be more appropriate. This behaviour has been described before here almost 6 years ago.
@bednee
Copy link
Owner

bednee commented Oct 7, 2016

I guess using URLs without protocol just as implemented in this PR #55 would fix this issue. Can you try to delete "http:" from the source and test it?

@JoJoAction
Copy link
Author

JoJoAction commented Oct 7, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoJoAction @bednee