Support redis connection options in BullMQ #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gtpan77 thoughts? Should we elide the |
|
Yes, we should do this change. Thanks @HalfdanJ |
skeggse
approved these changes
Nov 26, 2020
beequeueci
pushed a commit
that referenced
this pull request
Nov 26, 2020
### [3.6.1](v3.6.0...v3.6.1) (2020-11-26) ### Bug Fixes * support redis configuration with bullmq ([#294](#294)) ([ab4b806](ab4b806))
|
🎉 This PR is included in version 3.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BullMQ takes redis connections options in the format
{ connection: { host: ... } }instead of{ redis: { host: ... } }.This works well with connection settings as strings, havent tested passing in ioredis object