Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): remove dependency on handlebars-helpers #302

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

roychri
Copy link
Contributor

@roychri roychri commented Dec 14, 2020

This pull request removes the dependency on handlebars-helpers by creating ad hoc helpers to do the same tasks.

This removes 135 transitive dependencies, making node_modules much lighter, and removes 64 vulnerabilities.

This is a continuation of pull #227

Closes #226

@roychri
Copy link
Contributor Author

roychri commented Dec 14, 2020

@skeggse Is this what you were expecting?

Copy link
Member

@skeggse skeggse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good!

@skeggse skeggse changed the title fix(deps): remove dependency on handlebars-helpers feat(deps): remove dependency on handlebars-helpers Dec 14, 2020
@skeggse skeggse added this to the 3.7.0 milestone Dec 14, 2020
@skeggse skeggse merged commit bbacae8 into bee-queue:master Dec 16, 2020
@connorskees
Copy link

Thanks for finishing this!

beequeueci pushed a commit that referenced this pull request Dec 16, 2020
## [3.7.0](v3.6.1...v3.7.0) (2020-12-16)

### Features

* **deps:** remove dependency on `handlebars-helpers` ([#302](#302)) ([bbacae8](bbacae8))
@beequeueci
Copy link
Collaborator

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@roychri roychri deleted the fix-deps-remove-handlebars-helpers branch December 16, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on handlebars-helpers
4 participants