Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Securerandom #1805

Closed
jcrew99 opened this issue Dec 17, 2019 · 1 comment
Closed

Using Securerandom #1805

jcrew99 opened this issue Dec 17, 2019 · 1 comment
Assignees
@JessWill
Labels
Good First Issue ruby Pull requests for Ruby compatibility
Milestone
0.5.1.0

Comments

@jcrew99
Copy link
Collaborator

jcrew99 commented Dec 17, 2019

Since 2.4 is EOL due to the active record merge, in core/main/crypto.rb a to do is to utilise the SecureRandom gem to replace how a alphanumeric string is being generated, as it is not securely random.
@JessWill JessWill self-assigned this Jan 3, 2020
@JessWill JessWill mentioned this issue Jan 3, 2020
Merged
@JessWill
Copy link
Contributor

JessWill commented Jan 3, 2020

Done! :D

@JessWill JessWill closed this as completed Jan 3, 2020
@bcoles bcoles added this to the 0.5.1.0-alpha milestone Aug 15, 2021
@bcoles bcoles added ruby Pull requests for Ruby compatibility and removed Update labels Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessWill JessWill

Labels
Good First Issue ruby Pull requests for Ruby compatibility
Projects
None yet
Milestone
0.5.1.0
Development

No branches or pull requests
3 participants
@bcoles @jcrew99 @JessWill