Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action doesn't properly retag/push multi-arch images #1

Open
devnoname120 opened this issue Dec 9, 2024 · 1 comment
Open

Action doesn't properly retag/push multi-arch images #1

devnoname120 opened this issue Dec 9, 2024 · 1 comment

Comments

@devnoname120
Copy link

devnoname120 commented Dec 9, 2024

Here it only pushes the image sha256:b7668e756aabb86369fde2a5e38f9d477b5fb75374e42b8611f6fa9d49b4c76c (amd64) dropping sha256:27495c4423c6d85a4fab5943b045f6f27906f08a218430bb0c858e352d3678f9 (arm64) entirely.

> Run docker pull ghcr.io/devnoname120/bridge-manager:42c8a5ccda3febb51b9a33a9ab3f0f938ca058ad
42c8a5ccda3febb51b9a33a9ab3f0f938ca058ad: Pulling from devnoname120/bridge-manager

[…]

Digest: sha256:27495c4423c6d85a4fab5943b045f6f27906f08a218430bb0c858e352d3678f9
Status: Downloaded newer image for ghcr.io/devnoname120/bridge-manager:42c8a5ccda3febb51b9a33a9ab3f0f938ca058ad
ghcr.io/devnoname120/bridge-manager:42c8a5ccda3febb51b9a33a9ab3f0f938ca058ad

> Run docker tag ghcr.io/devnoname120/bridge-manager:42c8a5ccda3febb51b9a33a9ab3f0f938ca058ad ghcr.io/devnoname120/bridge-manager:latest

[…]

> Run docker push ghcr.io/devnoname120/bridge-manager:latest

[…]

latest: digest: sha256:b7668e756aabb86369fde2a5e38f9d477b5fb75374e42b8611f6fa9d49b4c76c size: 1999

https://github.com/devnoname120/bridge-manager/actions/runs/12237224918/job/34133496623


I'm not entirely sure why we need to do the retag in a separate action but if we keep this then I suspect that the solution would be to manually pull each platform separately (docker pull only pulls for the local platform), and then use build imagetools to actually retag it:

docker buildx imagetools create -t ${{ inputs.image }}:${{ github.sha }} ${{ inputs.image }}:latest

IMO it's awkward and it would be much easier to (conditionally) retag to :latest in a step after the build rather than in a separate action (the one in this repository).

@devnoname120 devnoname120 changed the title Action doesn't properly push multi-arch images Action doesn't properly retag/push multi-arch images Dec 9, 2024
@devnoname120
Copy link
Author

Related: beeper/bridge-manager#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant