Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beet move doesn't move existing album art files #3528

Closed
jallbrit opened this issue Mar 26, 2020 · 3 comments
Closed

beet move doesn't move existing album art files #3528

jallbrit opened this issue Mar 26, 2020 · 3 comments

Comments

@jallbrit
Copy link

jallbrit commented Mar 26, 2020

Let's say I have an album that's already in the beets database, but I change the default path to something else. Now, beets is supposed to move the existing folders to fit the new naming scheme.

However, it leaves behind the album art in the old folder, thus leaving a shell of the old folder structure with a bunch of cover.pngs in it, and I have to manually place them in the new, correct location.

If it is relevant, I downloaded this album art myself (as opposed to using a beets plugin).

Problem

You can see cover.png inside the folder, and that there's 140 files in the folder:

$ ls files/Game/Paper\ Mario_\ The\ Thousand\ Year\ Door/ | grep cover.png
cover.png
$ ls -1 files/Game/Paper\ Mario_\ The\ Thousand\ Year\ Door/ | wc -l
140

Running beet move doesn't pick up the album art, and only sees 139 items:

$ beet move -p
Moving 139 items (3758 already in place).
/home/john/Music/files/Game/Paper Mario_ The Thousand Year Door/01 Story of The Thousand Year Door.mp3 
  -> /home/john/Music/files/Yoshito Hirano & Yuka Tsujiyoko/Paper Mario_ The Thousand Year Door/01 Story of The Thousand Year Door.mp3
/home/john/Music/files/Game/Paper Mario_ The Thousand Year Door/03 Title Theme.mp3 
  -> /home/john/Music/files/Yoshito Hirano & Yuka Tsujiyoko/Paper Mario_ The Thousand Year Door/03 Title Theme.mp3
/home/john/Music/files/Game/Paper Mario_ The Thousand Year Door/04 Mail for the Mario Brothers.mp3 
  -> /home/john/Music/files/Yoshito Hirano & Yuka Tsujiyoko/Paper Mario_ The Thousand Year Door/04 Mail for the Mario Brothers.mp3
/home/john/Music/files/Game/Paper Mario_ The Thousand Year Door/05 A New Adventure Begins.mp3 
  -> /home/john/Music/files/Yoshito Hirano & Yuka Tsujiyoko/Paper Mario_ The Thousand Year Door/05 A New Adventure Begins.mp3


... [truncated] ...


  -> /home/john/Music/files/Yoshito Hirano & Yuka Tsujiyoko/Paper Mario_ The Thousand Year Door/137 A Last View at Rogueport.mp3
/home/john/Music/files/Game/Paper Mario_ The Thousand Year Door/138 Here We Go Again.mp3 
  -> /home/john/Music/files/Yoshito Hirano & Yuka Tsujiyoko/Paper Mario_ The Thousand Year Door/138 Here We Go Again.mp3
/home/john/Music/files/Game/Paper Mario_ The Thousand Year Door/139 Staff Roll.mp3 
  -> /home/john/Music/files/Yoshito Hirano & Yuka Tsujiyoko/Paper Mario_ The Thousand Year Door/139 Staff Roll.mp3
/home/john/Music/files/Game/Paper Mario_ The Thousand Year Door/140 Game Over.mp3 
  -> /home/john/Music/files/Yoshito Hirano & Yuka Tsujiyoko/Paper Mario_ The Thousand Year Door/140 Game Over.mp3

Setup

  • OS: Debian Testing
  • Python version: 3.7.7
  • beets version: 1.4.9
  • Turning off plugins made problem go away (yes/no): no

Beet config

directory: ~/Music/files
library: ~/.cache/beet/musiclibrary.db

ui:
  color: yes

import:
  autotag: no
  move: yes
  languages: en
@sampsyo
Copy link
Member

sampsyo commented Mar 26, 2020

Indeed; your art needs to be tracked by beets in order to be moved when this happens. You can use the fetchart plugin to pick up local art (aside from fetching art from web sources—you can disable those if you like).

@sampsyo sampsyo closed this as completed Mar 26, 2020
@jallbrit
Copy link
Author

To me, It seems like strange default behavior to completely ignore non-music files inside imported directories. It is my opinion that beets should pick up on possible art files, or at least have a flag to move all files inside the imported folder, not just music.

That being said, thank you for pointing this out to me! I did notice the plugin but failed to realize it could be restricted to local art.

@sampsyo
Copy link
Member

sampsyo commented Mar 26, 2020

Yes—it is certainly a common request to track arbitrary non-music files in the beets database. A long-standing idea to address that completely is "attachments" (#111), but it's a big job that no one has yet taken on. Separately, the third-party plugin copyartifacts solves most of the problem for most people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants