Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve chroma logging on fatal errors #5608

Open
JOJ0 opened this issue Jan 31, 2025 · 2 comments
Open

Improve chroma logging on fatal errors #5608

JOJ0 opened this issue Jan 31, 2025 · 2 comments

Comments

@JOJ0
Copy link
Member

JOJ0 commented Jan 31, 2025

When I execute a command

beet im -C -w -a -p .

I'm getting the following output:

Resuming interrupted import of /media/sda3/Music
python3: /usr/src/debug/chromaprint/chromaprint-1.5.1/src/audio_processor.cpp:148: virtual void chromaprint::AudioProcessor::Consume(const int16_t*, int): Assertion `length % m_num_channels == 0' failed.
[1]    936677 IOT instruction (core dumped)  beet im -C -w -a -p .

I think it misses critical information: which file it happened on. I could probably fix or delete the file, but currently, the application crashes and there is no way to find out which file it happened on.

Do you think it's something worth improving?

Originally posted by @asm0dey in #5601

@JOJ0
Copy link
Member Author

JOJ0 commented Jan 31, 2025

I agree that this makes sense to include in the log for an easy quickfix like deleting the file. Do you happen to find the time to file a quick PR for it @asm0dey? That would be 🚀

@asm0dey
Copy link

asm0dey commented Jan 31, 2025

@JOJ0 sorry I didn't have a single clue how to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants