Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuation allowed in Briefcase but not with Gradle #462

Closed
ProgrammAbel opened this issue Aug 1, 2020 · 3 comments
Closed

Punctuation allowed in Briefcase but not with Gradle #462

ProgrammAbel opened this issue Aug 1, 2020 · 3 comments
Labels
android The issue relates to Android mobile support. bug A crash or error in behavior. good first issue Is this your first time contributing? This could be a good place to start!

Comments

@ProgrammAbel
Copy link

ProgrammAbel commented Aug 1, 2020

Describe the bug
When creating an application, you are allowed to use punctuation for project names. However, when building for Android, the usage of /, \, :, <, >, ", ?, *, | are prohibited with Gradle.

To Reproduce
Steps to reproduce the behavior:

  1. Create an application with the name containing any one of the above characters.
  2. Build for Android.

Expected behavior
For the application to build successfully.

Screenshots
screenshot

Environment:

  • Operating System: Linux 5.7.10-arch1-1
  • Python version: Python 3.8.4
  • Software versions:
    • Briefcase: 0.3.3

Additional context
This is somewhat related to #460.

@ProgrammAbel ProgrammAbel added the bug A crash or error in behavior. label Aug 1, 2020
@freakboy3742 freakboy3742 added bug A crash or error in behavior. not quite right The idea or PR has been reviewed, but more work is needed. and removed bug A crash or error in behavior. labels Aug 2, 2020
@freakboy3742
Copy link
Member

Which "name" are you referring to - the "app name" or the "formal name"? The app name should be the only one that has restrictions; briefcase new and briefcase create both validates that your app name is PEP508 compliant (which rejects most 'special' characters). The Formal name should only be used for display purposes, and shouldn't be anywhere that is "special character sensitive".

So - what names were you using? Can you share your pyproject.toml?

@ProgrammAbel
Copy link
Author

Hi, thank you for your time. I'm not referring to either - I'm talking about the "project name", which allows punctuation and defaults to your formal name unless you set it as otherwise with briefcase new. I've created a new project (which still has the same issue) and I've attached it's pyproject.toml.

@freakboy3742 freakboy3742 added up-for-grabs good first issue Is this your first time contributing? This could be a good place to start! android The issue relates to Android mobile support. and removed not quite right The idea or PR has been reviewed, but more work is needed. labels Mar 25, 2022
@freakboy3742
Copy link
Member

This was fixed in #697.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android The issue relates to Android mobile support. bug A crash or error in behavior. good first issue Is this your first time contributing? This could be a good place to start!
Projects
None yet
Development

No branches or pull requests

2 participants