Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default Full Screen command #2865

Open
hyuri opened this issue Sep 22, 2024 · 1 comment
Open

Add default Full Screen command #2865

hyuri opened this issue Sep 22, 2024 · 1 comment
Labels
enhancement New features, or improvements to existing features.

Comments

@hyuri
Copy link

hyuri commented Sep 22, 2024

What is the problem or limitation you are having?

Much like #796, the default Full Screen shortcut(s) is(are) missing. Toga does not send the app into Full Screen when the default platform keyboard shortcut for Full Screen is pressed. (tested on macOS)

On macOS, two shortcuts are available by default: Command + Control + F and Fn + F.
On Windows and Linux, it's F11.

Describe the solution you'd like

Make the default platform keyboard shortcut for Full Screen trigger Full Screen.

Describe alternatives you've considered

None

Additional context

No response

@hyuri hyuri added the enhancement New features, or improvements to existing features. label Sep 22, 2024
@freakboy3742
Copy link
Member

Makes sense. We might need to wait until #2473 is finalised before it's possible to implement this, though.

The implementation on macOS would be a menu item View > Enter Full Screen with the shortcut (Fn + F). That menu item should change text to "Exit Full Screen" when you're in full screen mode.

I don't have access to my Windows and GTK boxes right now, so I can't confirm what an appropriate menu rendition on Windows or GTK would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

2 participants