-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I got welcomed for my first issue, but it wasn't my first issue #12
Comments
Thanks for the issue @nornagon. I actually had another report of this in the electron org a while back, and I wonder if the GH API is struggling with the volume of issues there?? I can't think of an issue on this app's end honestly. The code for the app is really simple: https://github.com/behaviorbot/new-issue-welcome/blob/master/index.js Maybe that you created the issue from a project board somehow made things weird? Anyways, I'll leave this issue to track any other repeats of this, but can't think of an immediate solution |
Happened again! electron/electron#14679 |
Aha! I thought it was odd the 2 people who reported this were high volume contributors. Currently the code filters out PRs, but doesn't iterate through pages of results. But you could have a page of 29 PRs and 1 issue but have other issues in older pages. The solution is to update the code to use the search API to get a more accurate query. I actually do this in one of the three welcomes: const res = await context.github.search.issues({q: `is:pr is:merged author:${creator} repo:${owner}/${repo}`}) But not the other two 🤷♀️ Thanks for reporting this! I'll put it on my to-do list :) |
This happened to me last week as well, should have reported it 😄 |
Got my third first issue today! electron/electron#15253 (comment) |
It seems that this only happens when the other issues have been deleted, making the new one your only -- "first" -- PR or issue. Supply more data if this doesn't appear to be the case. |
@Temerold electron/electron#15253 very much wasn't my only non-deleted issue on electron/electron at the time I created it. |
Weird... |
This happens to us in https://github.com/orchest/orchest/ from time to time as well. For example:
Do you have any idea what might be happening here? This is our config. |
electron/electron#13969 (comment)
Previously, electron/electron#12631
The text was updated successfully, but these errors were encountered: