Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting shaders to OpenGL 3.2 (first working version! yay ) #36

Closed
mgood7123 opened this issue Oct 29, 2021 · 6 comments
Closed

porting shaders to OpenGL 3.2 (first working version! yay ) #36

mgood7123 opened this issue Oct 29, 2021 · 6 comments

Comments

@mgood7123
Copy link

mgood7123 commented Oct 29, 2021

i am trying to port glyphy to OpenGL 3 (OpenGL 3.2 context) with #version 330 core and #version 320 es and i currently get no text rendered

it seems like the default GL context glew creates is 2.1 INTEL-14.7.8 (2.1) tho this might vary

these are my current changes https://github.com/mgood7123/glyphy-opengl3/commit/0104d65f225afa993ef0af3ea3ff135661fe3dc0

@mgood7123 mgood7123 changed the title porting shaders to OpenGL 3.2 (#version 330 core) porting shaders to OpenGL 3.2 Oct 29, 2021
@behdad
Copy link
Owner

behdad commented Oct 29, 2021

I'm open to that but have no experience to offer. Thanks!

@mgood7123
Copy link
Author

mgood7123 commented Oct 30, 2021

i got GL 3 to work, it now renders everything that OpenGL 2 could :)

https://github.com/mgood7123/glyphy-opengl3/commit/81e8412d9cb6bd9326c130f33b86efb7e941cb38

tho i had to rewrite part of the OPENGL block in demo-common.h to include GL3 headers, only tested on APPLE so not sure if headers will work on linux/windows/android yet

image

image

image

@mgood7123 mgood7123 changed the title porting shaders to OpenGL 3.2 porting shaders to OpenGL 3.2 (first working version! yay ) Oct 30, 2021
@behdad
Copy link
Owner

behdad commented Oct 30, 2021

Thanks! Let me test this on my Linux.

@behdad
Copy link
Owner

behdad commented Oct 30, 2021

Can you send a pull request?

@behdad
Copy link
Owner

behdad commented Oct 30, 2021

mgood7123/glyphy-opengl3@81e8412

Your GL_CHECK_ERROR changes are too noisy. Please use a macro like my existing gl to just prefix all sites that need checking so they look like:

  GL_CHECK glUseProgram (...);

@mgood7123
Copy link
Author

Can you send a pull request?

mgood7123/glyphy-opengl3@81e8412

Your GL_CHECK_ERROR changes are too noisy. Please use a macro like my existing gl to just prefix all sites that need checking so they look like:

  GL_CHECK glUseProgram (...);

fixed in #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants