-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSharpier Server - should have some form of log cleanup. #1330
Comments
Would you be ok with adding Serilog? There would be an auto cleanup for "free" |
I looked at it originally but settled on that lightweight logger instead. I don't recall the exact reason. I think it was either - Serilog bloated the size of the tool install and was way more than what was needed. Or getting serilog working was less straightforward. I'm not opposed to pulling it in assuming it doesn't bloat the tool install too much. |
Ok. I looked further into it. For me it looks like there's already a cleanup configured. The logFile will automatically role over after reaching 10mb and overwrite this file. Perhaps we can lower the file size and instead use more rolling files? Am I wrong on this? |
Right now csharpier server appends logs to server*.log files without limits or cleanup.
Perhaps on startup it should clean up any file that hasn't been touched in x days.
The text was updated successfully, but these errors were encountered: