Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support popup for react v16 #75

Open
stenin-nikita opened this issue Mar 27, 2018 · 0 comments
Open

Support popup for react v16 #75

stenin-nikita opened this issue Mar 27, 2018 · 0 comments

Comments

@stenin-nikita
Copy link

  • react version: 16.2.0
  • react-dom version: 16.2.0
  • bem-react-components version: master

Description:

When popup is rendered, the value of this._domNode is null. An error occurs here.

Uncaught TypeError: Cannot read property 'offsetWidth' of null (Popup_target.js:105)

This is most likely due to the fact that the render method in Portal-Popup returns null. Removing the method should solve the problem. Alternatively, you can use ReactDom.createPortal for react 16.
@stenin-nikita stenin-nikita changed the title Support popup for react v16.2.0 Support popup for react v16 Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stenin-nikita