This repository has been archived by the owner on Jan 13, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 72
Use lodash instead of underscore #94
Labels
Milestone
Comments
[release-1.0.0] bem-tools $ grep -P '[\s\b]_\.\w' ./ -r --exclude=jquery* --exclude-dir=node_modules --exclude-dir=bem-bl | sed -r -e 's/.*\s_\.(\w+).*/\1/' | sort | uniq
all
contains
defaults
difference
sortBy
union
uniq
$ grep -P '[\s\b]_\.\w' ./ -r --exclude=jquery* --exclude-dir=node_modules --exclude-dir=bem-bl
./test/bem-make.js: _.union(files, dirFiles).length === files.length;
./lib/util.js: opts = _.defaults(opts || {}, {
./lib/util.js: return _.all(needles, function(i) {
./lib/util.js: return _.contains(arr, i);
./lib/tech/v2.js: this._suffixes = _.uniq(res);
./lib/nodes/build.js: _.difference(filteredPaths, savedPaths));
./lib/nodes/build.js: var obsolete = _.difference(savedPaths, filteredPaths);
./lib/nodes/level.js: return _.uniq(
./lib/nodes/level.js: _.sortBy(
./lib/nodes/level.js: var r = _.uniq(
./lib/nodes/level.js: _.sortBy(
$ grep -P "require\(.underscore.\)" -r --exclude=jquery* --exclude-dir=node_modules --exclude-dir=bem-bl
test/bem-make.js: _ = require('underscore'),
lib/util.js: _ = require('underscore');
lib/tech/v2.js: _ = require('underscore'),
lib/nodes/build.js:var _ = require('underscore'),
lib/nodes/level.js: _ = require('underscore'), It's easily can be replaced ATM. |
@zxqfox We already replaced |
@arikon Please can you push your changes to |
Shame on me 21.10.2013, 16:54, "Sergej Tatarincev" notifications@github.com:
Отправлено из мобильной Яндекс.Почты: http://m.ya.ru/ymail |
@zxqfox Could you make a PR for the |
@arikon Sure. Added to my todo list. |
This was referenced Oct 24, 2013
SevInf
pushed a commit
that referenced
this issue
Nov 7, 2013
Conflicts: lib/util.js test/bem-make.js
SevInf
pushed a commit
that referenced
this issue
Nov 7, 2013
@SevInf Issuer resolved for 0.7 & 1.0. |
@zxqfox, thanks, closing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We can use lodash instead of underscore because it is 8x faster
https://github.com/bestiejs/lodash
The text was updated successfully, but these errors were encountered: