Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mods with numeric values does not match to string matchers #220

Closed
qfox opened this issue Mar 23, 2016 · 5 comments
Closed

Mods with numeric values does not match to string matchers #220

qfox opened this issue Mar 23, 2016 · 5 comments
Labels
scope: semantic semver: major type: enhancement
Milestone
7.0.0

Comments

@qfox
Copy link
Member

qfox commented Mar 23, 2016 •
edited by miripiruni
Loading

mod('a', 1) does not match { mods: { a: '1' } }.

As well as opposite:
mod('a', '1') does not match { mods: { a: 1 } }.

http://goo.gl/y1BOEY

Same with boolean modifiers with falsy values '' and false.
@miripiruni
Copy link
Contributor

miripiruni commented May 11, 2016 •
edited
Loading

We need to discuss current behaviour of mod() mode.
Here is showcase.

@miripiruni
Copy link
Contributor

We definitely should write about it in docs.

@qfox
Copy link
Member Author

qfox commented May 11, 2016

What's changed?

@miripiruni
Copy link
Contributor

miripiruni commented May 11, 2016 •
edited
Loading

@zxqfox look at my showcase. Is it bug? Or if so, what you expect?

@qfox
Copy link
Member Author

qfox commented May 11, 2016

We decided it's a bug the last time. What's changed?

@miripiruni miripiruni mentioned this issue May 12, 2016
Merged
@miripiruni miripiruni added this to the 7.0.0 milestone Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: semantic semver: major type: enhancement
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@miripiruni @qfox