Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working anymore, returns null #10

Open
ArsenicBismuth opened this issue Feb 22, 2020 · 1 comment
Open

Not working anymore, returns null #10

ArsenicBismuth opened this issue Feb 22, 2020 · 1 comment

Comments

@ArsenicBismuth
Copy link

Not working anymore. Running the modified example programs (to include ms) shows "8.8.8.8 null". Meanwhile running npm test gives result in the screenshot below. Meanwhile, testing in the same PowerShell with Windows' native ping command gives normal result.

Already checked firewall settings, such as allowing my Node.exe. Still no bueno.

image

@ArsenicBismuth
Copy link
Author

Found the problem, which is strangely fixed in your older branch under index.js.

Windows built-in ping returns with the following format 000ms, no space before the "ms".

So, modify this

this._regmatch = /[><=]([0-9.]+?) ms/;

Into this:

this._regmatch = /[><=]([0-9.]+?)ms/;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant