Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewBox will be removed regardless disabled plugin #42

Closed
bm2u opened this issue Apr 14, 2016 · 3 comments
Closed

ViewBox will be removed regardless disabled plugin #42

bm2u opened this issue Apr 14, 2016 · 3 comments

Comments

@bm2u
Copy link

bm2u commented Apr 14, 2016

As already mentioned in svgo gulp-svgmin does not respect the disabled "removeViewBox"-Plugin. My config looks like:

options : {
    plugins: [
        {
            removeViewBox: false
        },{
            addClassesToSVGElement: {
                classNames: ['svgo']
            }
        }
    ],
    js2svg: {
        pretty: true
    }
}

The class has been added to the svg element, but the viewbox unfortunately removed. Any ideas?

@bm2u bm2u changed the title ViewBox will be removed unless disabled plugin ViewBox will be removed regardless disabled plugin Apr 14, 2016
@ben-eb
Copy link
Owner

ben-eb commented Apr 14, 2016

The options are passed directly to SVGO, we don't do anything special here. Perhaps it has some trouble with your particular SVG input?

@bm2u
Copy link
Author

bm2u commented Apr 14, 2016

@ben-eb thx,known issue @ svgo.

@ben-eb
Copy link
Owner

ben-eb commented Apr 18, 2016

Closing this in favour of svg/svgo#505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants