Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-react-hooks #99

Closed
paean99 opened this issue Dec 24, 2018 · 4 comments
Closed

eslint-plugin-react-hooks #99

paean99 opened this issue Dec 24, 2018 · 4 comments

Comments

@paean99
Copy link
Contributor

paean99 commented Dec 24, 2018

I think that eslint-plugin-react-hooks is not used yet in this project. Since codeponder is using react hooks, I would be interesting to add them as they are part of the hooks proposal.

https://www.npmjs.com/package/eslint-plugin-react-hooks

@benawad
Copy link
Owner

benawad commented Dec 27, 2018

Is there a tslint version of this?

@paean99
Copy link
Contributor Author

paean99 commented Dec 27, 2018

There is a temporary solution from tslint-react which is a package for tslint and from the same developers at palantir/tslint-react#186 (comment)

I think the solution does need tslint-react but i haven't tested it yet.

@benawad
Copy link
Owner

benawad commented Dec 27, 2018

rather than setting up eslint for typescript, I think I'll just wait until tslint supports it

@benawad benawad closed this as completed Dec 27, 2018
@Gelio
Copy link

Gelio commented Feb 3, 2019

@benawad Take a look at a TSLint rule that detects possible misuses of hooks: https://github.com/Gelio/tslint-react-hooks

Disclaimer: I am the author. I noticed this issue referenced in another repo, so I thought I would let you know that you may try using that rule 🙂 I am looking for feedback 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants