Bug fix for allOf with no properties

Author: bowenwr

openapi_python_client/parser/openapi.py

@@ -279,7 +279,7 @@ def from_data(*, data: oai.Schema, name: str) -> Union["Model", ParseError]:
             for sub_prop in data.allOf:
                 if isinstance(sub_prop, oai.Reference):
                     references += [sub_prop]
-                else:
+                elif sub_prop.properties:
                     all_props.update(sub_prop.properties)
                     required_set.update(sub_prop.required or [])
 

tests/test_openapi_parser/test_openapi.py

@@ -173,12 +173,18 @@ def test_resolve_references(self, mocker):
                     "Float": oai.Schema.construct(type="number", format="float")
                 },
             ),
+            # Intentionally no properties defined
+            "RefC": oai.Schema.construct(
+                title=mocker.MagicMock(),
+                description=mocker.MagicMock(),
+            ),
         }
 
         model_schema = oai.Schema.construct(
             allOf=[
                 oai.Reference.construct(ref="#/components/schemas/RefA"),
                 oai.Reference.construct(ref="#/components/schemas/RefB"),
+                oai.Reference.construct(ref="#/components/schemas/RefC"),
                 oai.Schema.construct(
                     title=mocker.MagicMock(),
                     description=mocker.MagicMock(),
@@ -195,7 +201,6 @@ def test_resolve_references(self, mocker):
 
         model = Model.from_data(data=model_schema, name="Model")
         model.resolve_references(schemas)
-        print(f"{model=}")
         assert sorted(p.name for p in model.required_properties) == ["DateTime", "Float", "String"]
         assert all(p.required for p in model.required_properties)
         assert sorted(p.name for p in model.optional_properties) == ["Enum", "Int"]