Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For dotnet benchmarking the unit is currently hardcoded to nanosecond. Can it be derived from the json like for other benchmarks? #238

Open
lavakarthura opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lavakarthura
Copy link

We are using this tool to report our Dotnet Benchmarks but the default "nano second" unit is not very intuitive. Also we want to add custom columns which can report throughput in unit like "GBps" etc. Both are not feasible because it appears the unit is hardcoded to "ns" - https://github.com/benchmark-action/github-action-benchmark/blob/master/src/extract.ts#L656

@ktrz ktrz added the bug Something isn't working label Apr 11, 2024
@ktrz ktrz self-assigned this Apr 11, 2024
@ktrz ktrz moved this from Todo to In Progress in Benchmark Action Board Apr 11, 2024
@ktrz ktrz moved this from In Progress to Todo in Benchmark Action Board Apr 11, 2024
@ktrz
Copy link
Member

ktrz commented Apr 11, 2024

Hi @lavakarthura

Thank you for filing this issue. We are using the json exported file and I could not find any reference to the unit there. This is the output we are using

If possible, please provide an example benchmark or its output so I can use it for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants