Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip should default to commit author not committer #260

Open
martincostello opened this issue Aug 13, 2024 · 0 comments
Open

Tooltip should default to commit author not committer #260

martincostello opened this issue Aug 13, 2024 · 0 comments

Comments

@martincostello
Copy link
Contributor

When tooltips for the commit data are rendered, they give the name of the user who committed the commit.

return '\n' + data.commit.message + '\n\n' + data.commit.timestamp + ' committed by @' + data.commit.committer.username + '\n';

This is not always useful, as merge and squash commits are committed by web-flow. The author is a better value to use.

I've used the template index to write my own UI, so it's easy to change with custom code, but I think it makes sense to render the default built-in pages that way too.

- return '\n' + data.commit.message + '\n\n' + data.commit.timestamp + ' committed by @' + data.commit.committer.username + '\n';
+ return '\n' + data.commit.message + '\n\n' + data.commit.timestamp + ' committed by @' + data.commit.author.username + '\n';
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant