Fix subprocess sampling #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain cases subprocess sampling was failing. This was related to the process info map we were sending back with the samples. When a process exitted we cleaned up the information about the process from the map, but in another thread was accessing to display the process hierarchy. Fix by not returning the process info map to the caller, and instead return a linked list of process information (that is immutable and ref counted) with each sample.
This was referenced Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases subprocess sampling was failing. This was related to the process
info map we were sending back with the samples. When a process exitted we
cleaned up the information about the process from the map, but in another thread
was accessing to display the process hierarchy.
Fix by not returning the process info map to the caller, and instead return a
linked list of process information (that is immutable and ref counted) with
each sample.