Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unbounded flamegraph sampling #60

Closed
masklinn opened this issue Nov 16, 2018 · 3 comments
Closed

Allow unbounded flamegraph sampling #60

masklinn opened this issue Nov 16, 2018 · 3 comments

Comments

@masklinn
Copy link

When trying to sample desktop or web applications, the triggers are generally some user interaction until the end of whatever it did, with the "whatever" being only loosely specified time-wise possibly ranging from a fraction of a second to several minutes (e.g. a complex import process).

The current time-bound sampling duration is really inconvenient for this, it would be nice if like the "top" mode it were possible to start sampling and have the sampling only end when e.g. C-c is sent to py-spy.

@benfred
Copy link
Owner

benfred commented Nov 16, 2018

Hrm - I think I messed up somewhere, this is supposed to be happening right now (with this commit 290584d).

Edit: this commit was after the last release - will be fixed in the next release.

@masklinn
Copy link
Author

masklinn commented Nov 16, 2018

Excellent, I had not seen that. Too bad that it missed the release by 2 days / a commit.

I'll close this then, #21 is fine, thanks, and looking forward to the next release.

@benfred
Copy link
Owner

benfred commented Dec 6, 2018

Change is in v0.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants