Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider deprecate filters with dash #33

Open
LC43 opened this issue Feb 6, 2017 · 1 comment
Open

consider deprecate filters with dash #33

LC43 opened this issue Feb 6, 2017 · 1 comment

Comments

@LC43
Copy link

LC43 commented Feb 6, 2017

Hi, great plugin!

Would you consider deprecating your filters with dash and replace them with underscores?
WP coding standards advice to use underscores in filters/actions.

I would suggest just deprecating for now, and only in future, to remove it.

thanks

@benhuson
Copy link
Owner

benhuson commented Feb 8, 2017

Yes, that sounds like a good idea.

As part of that I would probably review how filters are used through the plugin and the arguments that can be passed to them.

Not something I have tim to jump in and do at the moment, but will certain consider doing this in due course.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants