Merge pull request #837 from benmosher/release-2.3.0

Release 2.3.0

CHANGELOG.md

@@ -6,6 +6,21 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 ## [Unreleased]
 
 
+## [2.3.0] - 2017-05-18
+### Added
+- [`no-anonymous-default-export`] rule: report anonymous default exports ([#712], thanks [@duncanbeevers]).
+- Add new value to [`order`]'s `newlines-between` option to allow newlines inside import groups ([#627], [#628], thanks [@giodamelio])
+- Add `count` option to the [`newline-after-import`] rule to allow configuration of number of newlines expected ([#742], thanks [@ntdb])
+
+### Changed
+- [`no-extraneous-dependencies`]: use `read-pkg-up` to simplify finding + loading `package.json` ([#680], thanks [@wtgtybhertgeghgtwtg])
+- Add support to specify the package.json [`no-extraneous-dependencies`] ([#685], thanks [@ramasilveyra])
+
+### Fixed
+- attempt to fix crash in [`no-mutable-exports`]. ([#660])
+- "default is a reserved keyword" in no-maned-default tests by locking down babylon to 6.15.0 (#756, thanks @gmathieu)
+
+
 ## [2.2.0] - 2016-11-07
 ### Fixed
 - Corrected a few gaffs in the auto-ignore logic to fix major performance issues
@@ -371,10 +386,16 @@ for info on changes for earlier releases.
 [`no-webpack-loader-syntax`]: ./docs/rules/no-webpack-loader-syntax.md
 [`no-unassigned-import`]: ./docs/rules/no-unassigned-import.md
 [`unambiguous`]: ./docs/rules/unambiguous.md
+[`no-anonymous-default-export`]: ./docs/rules/no-anonymous-default-export.md
 
+[#742]: https://github.com/benmosher/eslint-plugin-import/pull/742
+[#712]: https://github.com/benmosher/eslint-plugin-import/pull/712
+[#685]: https://github.com/benmosher/eslint-plugin-import/pull/685
+[#680]: https://github.com/benmosher/eslint-plugin-import/pull/680
 [#654]: https://github.com/benmosher/eslint-plugin-import/pull/654
 [#639]: https://github.com/benmosher/eslint-plugin-import/pull/639
 [#630]: https://github.com/benmosher/eslint-plugin-import/pull/630
+[#628]: https://github.com/benmosher/eslint-plugin-import/pull/628
 [#596]: https://github.com/benmosher/eslint-plugin-import/pull/596
 [#586]: https://github.com/benmosher/eslint-plugin-import/pull/586
 [#578]: https://github.com/benmosher/eslint-plugin-import/pull/578
@@ -424,7 +445,9 @@ for info on changes for earlier releases.
 [#157]: https://github.com/benmosher/eslint-plugin-import/pull/157
 [#314]: https://github.com/benmosher/eslint-plugin-import/pull/314
 
+[#660]: https://github.com/benmosher/eslint-plugin-import/issues/660
 [#653]: https://github.com/benmosher/eslint-plugin-import/issues/653
+[#627]: https://github.com/benmosher/eslint-plugin-import/issues/627
 [#609]: https://github.com/benmosher/eslint-plugin-import/issues/609
 [#604]: https://github.com/benmosher/eslint-plugin-import/issues/604
 [#602]: https://github.com/benmosher/eslint-plugin-import/issues/602
@@ -479,7 +502,8 @@ for info on changes for earlier releases.
 [#119]: https://github.com/benmosher/eslint-plugin-import/issues/119
 [#89]: https://github.com/benmosher/eslint-plugin-import/issues/89
 
-[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v2.2.0...HEAD
+[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v2.3.0...HEAD
+[2.3.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.2.0...v2.3.0
 [2.2.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.1.0...v2.2.0
 [2.1.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.0.1...v2.1.0
 [2.0.1]: https://github.com/benmosher/eslint-plugin-import/compare/v2.0.0...v2.0.1
@@ -553,3 +577,8 @@ for info on changes for earlier releases.
 [@fson]: https://github.com/fson
 [@ntdb]: https://github.com/ntdb
 [@jakubsta]: https://github.com/jakubsta
+[@wtgtybhertgeghgtwtg]: https://github.com/wtgtybhertgeghgtwtg
+[@duncanbeevers]: https://github.com/duncanbeevers
+[@giodamelio]: https://github.com/giodamelio
+[@ntdb]: https://github.com/ntdb
+[@ramasilveyra]: https://github.com/ramasilveyra

README.md

@@ -76,6 +76,7 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 * Limit the maximum number of dependencies a module can have ([`max-dependencies`])
 * Forbid unassigned imports ([`no-unassigned-import`])
 * Forbid named default exports ([`no-named-default`])
+* Forbid anonymous values as default exports ([`no-anonymous-default-export`])
 
 [`first`]: ./docs/rules/first.md
 [`no-duplicates`]: ./docs/rules/no-duplicates.md
@@ -87,6 +88,7 @@ This plugin intends to support linting of ES2015+ (ES6+) import/export syntax, a
 [`max-dependencies`]: ./docs/rules/max-dependencies.md
 [`no-unassigned-import`]: ./docs/rules/no-unassigned-import.md
 [`no-named-default`]: ./docs/rules/no-named-default.md
+[`no-anonymous-default-export`]: ./docs/rules/no-anonymous-default-export.md
 
 ## Installation
 

docs/rules/named.md

@@ -10,7 +10,7 @@ Redux's npm module includes this key, and thereby is lintable, for example.
 
 A module path that is [ignored] or not [unambiguously an ES module] will not be reported when imported.
 
-[ignored]: ../README.md#importignore
+[ignored]: ../../README.md#importignore
 [unambiguously an ES module]: https://github.com/bmeck/UnambiguousJavaScriptGrammar
 
 

docs/rules/newline-after-import.md

@@ -1,9 +1,11 @@
 # newline-after-import
 
-Enforces having an empty line after the last top-level import statement or require call.
+Enforces having one or more empty lines after the last top-level import statement or require call.
 
 ## Rule Details
 
+This rule has one option, `count` which sets the number of newlines that are enforced after the last top-level import statement or require call. This option defaults to `1`.
+
 Valid:
 
 ```js
@@ -26,7 +28,7 @@ const BAR = require('./bar')
 const BAZ = 1
 ```
 
-...whereas here imports will be reported:
+Invalid:
 
 ```js
 import * as foo from 'foo'
@@ -46,6 +48,40 @@ const BAZ = 1
 const BAR = require('./bar')
 ```
 
+With `count` set to `2` this will be considered valid:
+
+```js
+import defaultExport from './foo'
+
+
+const FOO = 'BAR'
+```
+
+With `count` set to `2` these will be considered invalid:
+
+```js
+import defaultExport from './foo'
+const FOO = 'BAR'
+```
+
+```js
+import defaultExport from './foo'
+
+const FOO = 'BAR'
+```
+
+
+## Example options usage
+```
+{
+  ...
+  "rules": {
+    "import/newline-after-import": [{ "count": 2 }]
+  }
+}
+```
+
+
 ## When Not To Use It
 
 If you like to visually group module imports with its usage, you don't want to use this rule.

docs/rules/no-amd.md

@@ -1,6 +1,6 @@
 # no-amd
 
-Reports `require([array], ...)` and `define([array], ...) function calls at the
+Reports `require([array], ...)` and `define([array], ...)` function calls at the
 module scope. Will not report if !=2 arguments, or first argument is not a literal array.
 
 Intended for temporary use when migrating to pure ES6 modules.

docs/rules/no-anonymous-default-export.md

@@ -0,0 +1,67 @@
+# no-anonymous-default-export
+
+Reports if a module's default export is unnamed. This includes several types of unnamed data types; literals, object expressions, arrays, anonymous functions, arrow functions, and anonymous class declarations.
+
+Ensuring that default exports are named helps improve the grepability of the codebase by encouraging the re-use of the same identifier for the module's default export at its declaration site and at its import sites.
+
+## Options
+
+By default, all types of anonymous default exports are forbidden, but any types can be selectively allowed by toggling them on in the options.
+
+The complete default configuration looks like this.
+
+```js
+"import/no-anonymous-default-export": ["error", {
+  "allowArray": false,
+  "allowArrowFunction": false,
+  "allowAnonymousClass": false,
+  "allowAnonymousFunction": false,
+  "allowLiteral": false,
+  "allowObject": false
+}]
+```
+
+## Rule Details
+
+### Fail
+```js
+export default []
+
+export default () => {}
+
+export default class {}
+
+export default function () {}
+
+export default 123
+
+export default {}
+```
+
+### Pass
+```js
+const foo = 123
+export default foo
+
+export default class MyClass() {}
+
+export default function foo() {}
+
+/* eslint import/no-anonymous-default-export: [2, {"allowArray": true}] */
+export default []
+
+/* eslint import/no-anonymous-default-export: [2, {"allowArrowFunction": true}] */
+export default () => {}
+
+/* eslint import/no-anonymous-default-export: [2, {"allowAnonymousClass": true}] */
+export default class {}
+
+/* eslint import/no-anonymous-default-export: [2, {"allowAnonymousFunction": true}] */
+export default function () {}
+
+/* eslint import/no-anonymous-default-export: [2, {"allowLiteral": true}] */
+export default 123
+
+/* eslint import/no-anonymous-default-export: [2, {"allowObject": true}] */
+export default {}
+```

docs/rules/no-dynamic-require.md

@@ -19,6 +19,5 @@ require(name());
 
 ```js
 require('../name');
-require('../name' + name);
 require(`../name`);
 ```

docs/rules/no-extraneous-dependencies.md

@@ -1,7 +1,7 @@
 # Forbid the use of extraneous packages
 
 Forbid the import of external modules that are not declared in the `package.json`'s `dependencies`, `devDependencies`, `optionalDependencies` or `peerDependencies`.
-The closest parent `package.json` will be used. If no `package.json` is found, the rule will not lint anything.
+The closest parent `package.json` will be used. If no `package.json` is found, the rule will not lint anything. This behaviour can be changed with the rule option `packageDir`.
 
 ### Options
 
@@ -25,7 +25,13 @@ You can also use an array of globs instead of literal booleans:
 "import/no-extraneous-dependencies": ["error", {"devDependencies": ["**/*.test.js", "**/*.spec.js"]}]
 ```
 
-When using an array of globs, the setting will be activated if the name of the file being linted matches a single glob in the array.
+When using an array of globs, the setting will be set to `true` (no errors reported) if the name of the file being linted matches a single glob in the array, and `false` otherwise.
+
+Also there is one more option called `packageDir`, this option is to specify the path to the folder containing package.json and is relative to the current working directory.
+
+```js
+"import/no-extraneous-dependencies": ["error", {"packageDir": './some-dir/'}]
+```
 
 ## Rule Details
 

docs/rules/no-named-as-default.md

@@ -27,7 +27,7 @@ import foo from './foo.js';
 import bar from './foo.js';
 ```
 
-For post-ES2015 `export` extensions, this also prevents exporting the default from a referenced module as a name within than module, for the same reasons:
+For post-ES2015 `export` extensions, this also prevents exporting the default from a referenced module as a name within that module, for the same reasons:
 
 ```js
 // valid:

docs/rules/no-unresolved.md

@@ -11,7 +11,7 @@ This rule can also optionally report on unresolved modules in CommonJS `require(
 To enable this, send `{ commonjs: true/false, amd: true/false }` as a rule option.
 Both are disabled by default.
 
-If you are using Webpack, see the section on [resolver plugins](../../README.md#resolver-plugins).
+If you are using Webpack, see the section on [resolvers](../../README.md#resolvers).
 
 ## Rule Details
 

docs/rules/order.md

@@ -92,13 +92,14 @@ You can set the options like this:
 "import/order": ["error", {"groups": ["index", "sibling", "parent", "internal", "external", "builtin"]}]
 ```
 
-### `newlines-between: [ignore|always|never]`:
+### `newlines-between: [ignore|always|always-and-inside-groups|never]`:
 
 
 Enforces or forbids new lines between import groups:
 
 - If set to `ignore`, no errors related to new lines between import groups will be reported (default).
 - If set to `always`, at least one new line between each group will be enforced, and new lines inside a group will be forbidden. To prevent multiple lines between imports, core `no-multiple-empty-lines` rule can be used.
+- If set to `always-and-inside-groups`, it will act like `always` except newlines are allowed inside import groups.
 - If set to `never`, no new lines are allowed in the entire import section.
 
 With the default group setting, the following will be invalid:
@@ -111,6 +112,15 @@ import index from './';
 import sibling from './foo';
 ```
 
+```js
+/* eslint import/order: ["error", {"newlines-between": "always-and-inside-groups"}] */
+import fs from 'fs';
+
+import path from 'path';
+import index from './';
+import sibling from './foo';
+```
+
 ```js
 /* eslint import/order: ["error", {"newlines-between": "never"}] */
 import fs from 'fs';
@@ -133,6 +143,17 @@ import index from './';
 import sibling from './foo';
 ```
 
+```js
+/* eslint import/order: ["error", {"newlines-between": "always-and-inside-groups"}] */
+import fs from 'fs';
+
+import path from 'path';
+
+import index from './';
+
+import sibling from './foo';
+```
+
 ```js
 /* eslint import/order: ["error", {"newlines-between": "never"}] */
 import fs from 'fs';

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-import",
-  "version": "2.2.0",
+  "version": "2.3.0",
   "description": "Import with sanity.",
   "engines": {
     "node": ">=4"
@@ -51,10 +51,11 @@
     "babel-eslint": "next",
     "babel-plugin-istanbul": "^2.0.1",
     "babel-preset-es2015-argon": "latest",
-    "babel-register": "6.16.3",
+    "babel-register": "6.24.1",
+    "babylon": "6.15.0",
     "chai": "^3.4.0",
     "coveralls": "^2.11.4",
-    "cross-env": "^3.1.0",
+    "cross-env": "^4.0.0",
     "eslint": "3.x",
     "eslint-import-resolver-node": "file:./resolvers/node",
     "eslint-import-resolver-webpack": "file:./resolvers/webpack",
@@ -69,7 +70,7 @@
     "redux": "^3.0.4",
     "rimraf": "2.5.2",
     "typescript": "^2.0.3",
-    "typescript-eslint-parser": "^0.4.0"
+    "typescript-eslint-parser": "^2.1.0"
   },
   "peerDependencies": {
     "eslint": "2.x - 3.x"
@@ -84,7 +85,7 @@
     "has": "^1.0.1",
     "lodash.cond": "^4.3.0",
     "minimatch": "^3.0.3",
-    "pkg-up": "^1.0.0"
+    "read-pkg-up": "^2.0.0"
   },
   "nyc": {
     "require": [

resolvers/node/CHANGELOG.md

@@ -4,6 +4,12 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 This change log adheres to standards from [Keep a CHANGELOG](http://keepachangelog.com).
 
 ## Unreleased
+
+
+## v0.3.0 - 2016-12-15
+### Changed
+- bumped `resolve` to fix issues with Node builtins (thanks [@SkeLLLa] and [@ljharb])
+
 ### Fixed
 - use `files` in `package.json` to ship only `index.js` ([#531], thanks for noticing [@lukeapage])
 
@@ -31,3 +37,5 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 
 [@jasonkarns]: https://github.com/jasonkarns
 [@lukeapage]: https://github.com/lukeapage
+[@SkeLLLa]: https://github.com/SkeLLLa
+[@ljharb]: https://github.com/ljharb