Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .coffee test proving extension resolve order #1010

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Add a .coffee test proving extension resolve order #1010

merged 1 commit into from
Feb 2, 2018

Conversation

silvenon
Copy link
Contributor

@silvenon silvenon commented Feb 2, 2018

Sending this PR just in case it's useful and connects some dots, feel free to close otherwise.


Add a test for a more unconventional extension to prove that the extensions rule can take anything as long as the extension resolve order is correct, i.e. it can only remove the extension if it would resolve to the correct file.

I was thinking about documenting this behavior, but it's already documented.

Ref. #965.
Closes #583.

Add a test for a more unconventional extension to prove that the
"extensions" rule can take anything, as long as the extension resolve
order is correct, i.e. it can only remove the extension if it would
resolve to the correct file.

Ref. #965.
Closes #583.
@coveralls
Copy link

coveralls commented Feb 2, 2018

Coverage Status

Coverage remained the same at 96.225% when pulling fdcd4d9 on silvenon:extensions into bc50394 on benmosher:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

import/extensions: does not complain about .coffee
3 participants