Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix newline-after-import example #845

Merged
merged 1 commit into from
Jan 4, 2018
Merged

[docs] Fix newline-after-import example #845

merged 1 commit into from
Jan 4, 2018

Conversation

daltones
Copy link
Contributor

Fix missing error level in “Example options usage” and add JS highlighting.

@daltones @ljharb
[docs] Fix newline-after-import example
cf60a20 
Fix missing error level in “Example options usage” and add JS highlighting.
@coveralls
Copy link

coveralls commented May 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 95.059% when pulling 5dc9ff7 on daltones:patch-2 into b79e083 on benmosher:master.

ljharb
ljharb requested changes May 25, 2017
View reviewed changes
docs/rules/newline-after-import.md Outdated
@@ -72,11 +72,11 @@ const FOO = 'BAR'


## Example options usage
```
```js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint config should really be json

docs/rules/newline-after-import.md Outdated
{
...
// ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we can just remove this line then

@coveralls
Copy link

coveralls commented May 26, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 95.059% when pulling b9dedcb on daltones:patch-2 into b79e083 on benmosher:master.

@ljharb ljharb added the docs label Jan 4, 2018
@ljharb ljharb self-assigned this Jan 4, 2018
@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 96.212% when pulling fd4b886 on daltones:patch-2 into 523789f on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 96.212% when pulling fd4b886 on daltones:patch-2 into 523789f on benmosher:master.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.203% when pulling cf60a20 on daltones:patch-2 into 9ce605d on benmosher:master.

@ljharb ljharb merged commit 697afb2 into import-js:master Jan 4, 2018
@renovate renovate bot mentioned this pull request Feb 22, 2018
Merged
@renovate renovate bot mentioned this pull request Mar 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

@ljharb ljharb

Labels
docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltones @coveralls @ljharb