Handle call expressions in the no-anonymous-default-export rule #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 29, 2017
| @@ -43,6 +44,7 @@ ruleTester.run('no-anonymous-default-export', rule, { | |||
| test({ code: 'export default \'foo\'', errors: [{ message: 'Assign literal to a variable before exporting as module default' }] }), | |||
| test({ code: 'export default `foo`', errors: [{ message: 'Assign literal to a variable before exporting as module default' }] }), | |||
| test({ code: 'export default {}', errors: [{ message: 'Assign object to a variable before exporting as module default' }] }), | |||
| test({ code: 'export default foo(bar)', errors: [{ message: 'Assign call result to a variable before exporting as module default' }] }), | |||
There was a problem hiding this comment.
this constitutes a breaking change if it's false by default; it'd need to default to true so it can be semver-minor
There was a problem hiding this comment.
Ahh, yes. Will fix that.
|
Apparently the "default" property of the JSON schema is ignored by ESLint, so I added a bit of code that generates defaults. |
ljharb
approved these changes
Nov 30, 2017
1 similar comment
ljharb
force-pushed
the
no-anonymous-call-default-export
branch
from
020ce05
to
1739d6b
Compare
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call expressions are not handled by the
no-anonymous-default-exportrule... not anymore!Previously:
After the PR: