Fix import/order autofixer when using typescript-eslint-parser #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ofixer `typescript-eslint-parser` does not add `.start` and `.end` to nodes like `babel-eslint`. They both include a `range` that can be used isntead.
justinanastos
force-pushed
the
fix/typescript-import-order-1086
branch
from
1779242 to
8d02f32
Compare
|
Closing to refire CI again |
ljharb
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1086 (comment)
Why?
When using
typescript-eslint-parser, AST nodes have arangetrie but notstartandend. Apparentlyeslintprefers usingrangeinstead of.startand.endas well, see eslint/eslint#8956.How
Replace use of
.startand.endwithrange[0]andrange[1]respectively in theorderrule.Test
I added a test to reproduce the error and then a separate commit to prove this fixes it. All other tests pass.