fix [import/named] for importing from a module which re-exports named exports from a node_modules module #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
commented
Aug 7, 2019
| @@ -26,6 +26,7 @@ ruleTester.run('named', rule, { | |||
| test({code: 'import { destructingRenamedAssign } from "./named-exports"'}), | |||
| test({code: 'import { ActionTypes } from "./qc"'}), | |||
| test({code: 'import {a, b, c, d} from "./re-export"'}), | |||
| test({code: 'import {RuleTester} from "./re-export-node_modules"'}), | |||
There was a problem hiding this comment.
I chose eslint as the node_module and RuleTester as the import because I figured that'd be pretty stable. It's unlikely that export would change, and in the event that it does, we'll need to update this test file quite a bit anyway.
ljharb
force-pushed
the
pr/export-star-named
branch
from
1e62911 to
cc5bde5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a failing test for #1446
I'm not sure how to proceed, but hopefully this helps someone diagnose the issue.