Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] no-extraneous-dependencies: Exclude flow typeof imports #1534

Merged
merged 1 commit into from
Feb 1, 2021
Merged

[Fix] no-extraneous-dependencies: Exclude flow typeof imports #1534

merged 1 commit into from
Feb 1, 2021

Conversation

devongovett
Copy link
Contributor

Type imports were already ignored, but typeof imports should also be ignored.

For example:

// @flow
import typeof TypeScriptModule from 'typescript';

@devongovett @ljharb
[Fix] no-extraneous-dependencies: Exclude flow typeof imports
f2db74a 
Co-authored-by: Devon Govett <devongovett@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@coveralls
Copy link

coveralls commented Nov 2, 2019 •
edited
Loading

Coverage Status

Coverage increased (+5.7%) to 71.388% when pulling f2db74a on devongovett:patch-1 into 1031e1c on benmosher:master.

@ljharb ljharb added the flow label Dec 5, 2019
ljharb
ljharb requested changes Dec 5, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add a regression test for this?

ljharb
ljharb approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, and went ahead and used the code in your OP as a test case.

@ljharb ljharb merged commit f2db74a into import-js:master Feb 1, 2021
@ljharb ljharb changed the title Exclude flow typeof imports from extraneous dependencies [Fix] no-extraneous-dependencies: Exclude flow typeof imports Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
flow
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devongovett @coveralls @ljharb