New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] `order`: Add TS import type tests #1736

Merged

ljharb merged 1 commit into import-js:master from kmui2:ts-type-import-order

May 31, 2020

Contributor

kmui2 commented Apr 27, 2020

Add TypeScript import type tests for import/order rule in #1667.


          [Tests] order: Add TS import type tests

eb2b7ea

Co-authored-by: Kevin Mui <kmui2@wisc.edu>
Co-authored-by: Jordan Harband <ljharb@gmail.com>

coveralls commented Apr 27, 2020 •

edited

Loading

Coverage increased (+0.04%) to 97.787% when pulling eb2b7ea on kmui2:ts-type-import-order into 6159ce9 on benmosher:master.

coveralls commented Apr 27, 2020

Coverage remained the same at 97.739% when pulling 9ff2835 on kmui2:ts-type-import-order into 92caa35 on benmosher:master.

4 similar comments

coveralls commented Apr 27, 2020

Coverage remained the same at 97.739% when pulling 9ff2835 on kmui2:ts-type-import-order into 92caa35 on benmosher:master.

coveralls commented Apr 27, 2020

Coverage remained the same at 97.739% when pulling 9ff2835 on kmui2:ts-type-import-order into 92caa35 on benmosher:master.

coveralls commented Apr 27, 2020

Coverage remained the same at 97.739% when pulling 9ff2835 on kmui2:ts-type-import-order into 92caa35 on benmosher:master.

coveralls commented Apr 27, 2020

Coverage remained the same at 97.739% when pulling 9ff2835 on kmui2:ts-type-import-order into 92caa35 on benmosher:master.

WolfgangKluge commented May 2, 2020

Btw. import type * as name from "..."; is perfectly valid and thus should be in the test's, too.
This syntax is not mentioned in the typescript docs, but the compiler has no problem with it...

ljharb added the typescript label

ljharb approved these changes

View reviewed changes

ljharb force-pushed the ts-type-import-order branch 2 times, most recently from be218ed to a6a0b54 Compare

May 31, 2020 07:57

Member

ljharb commented May 31, 2020

Figured out the node type name in eslint v2 :-)

ljharb force-pushed the ts-type-import-order branch from a6a0b54 to eb2b7ea Compare

May 31, 2020 08:36

ljharb merged commit eb2b7ea into import-js:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels