support alt-JS dependencies #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| context('alternate parsers', function () { | ||
| const configs = [ | ||
| // ['string form', { 'typescript-eslint-parser': '.ts' }], | ||
| ['array form', { 'typescript-eslint-parser': ['.ts', '.tsx'] }], |
There was a problem hiding this comment.
What is the reason that the string form one is commented out?
There was a problem hiding this comment.
I started with just one string, then made it support both a string and an array.
Then I decided I was making it too complicated.
Do you think it would be better to support both?
This was referenced Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407. Allows TypeScript or other alt-JS dependencies to be configured via
import/parserssetting.cc @santiagoaguiar, @denneulin for feedback since you two 👍'd the original issue I created. 😎