Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_attachment does not consider '_rev_' #192

Open
dedalus2000 opened this issue Oct 11, 2016 · 0 comments
Open

fetch_attachment does not consider '_rev_' #192

dedalus2000 opened this issue Oct 11, 2016 · 0 comments

Comments

@dedalus2000
Copy link

As far I can see (and test) fetch_attachment does not consider the _rev field when it is passed in the "doc".

This can cause problems: we are going to get always the latest document, avoiding any conflict.

Here my patch:

$ diff client.py ~/sources/couchdbkit-0.6.5/couchdbkit/client.py 
855d854
<             doc = {}
863c862
<         resp = self.res(docid).get(name, headers=headers, rev=doc.get('_rev'))

---
>         resp = self.res(docid).get(name, headers=headers)
@dedalus2000 dedalus2000 changed the title fetch_attachment does not consider '_rev_ fetch_attachment does not consider '_rev_' Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant