Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

won't encode special character in http get url path #176

Closed
linbo opened this issue Mar 16, 2015 · 1 comment
Closed

won't encode special character in http get url path #176

linbo opened this issue Mar 16, 2015 · 1 comment

Comments

@linbo
Copy link

linbo commented Mar 16, 2015

Hi,

I have an restful server with an url like this:

http://host:port/id/name:107/?type=FS

Since there is an special character colon in the path, I've checked code, find those codes in hackney.erl

request(Method, #hackney_url{}=URL0, Headers, Body, Options0) ->
    %% normalize the url encoding
    URL = hackney_url:normalize(URL0),

Actually, I won't wan't encode colon in URL, but maybe in query parameters, but the code seems encode all the URL.

If I use httpc:get, looks working fine.

@benoitc
Copy link
Owner

benoitc commented Mar 20, 2015

mmm Is this a valid syntax though? Hackney is reusing the algorithm you can find in chrome. I will check the spec anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants