Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninitialized constant GoodJob::Process #1006

Closed
gap777 opened this issue Jul 11, 2023 · 2 comments · Fixed by #1007
Closed

uninitialized constant GoodJob::Process #1006

gap777 opened this issue Jul 11, 2023 · 2 comments · Fixed by #1007

Comments

@gap777
Copy link
Contributor

gap777 commented Jul 11, 2023

Saw this in logs after updating to 3.15.14

[GoodJob] Notifier errored: NameError: uninitialized constant GoodJob::Process

15:44:27 web.1  |  ["/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/good_job-3.15.14/lib/good_job/notifier/process_heartbeat.rb:24:in `refresh_process'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:400:in `block in make_lambda'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:199:in `block (2 levels) in halting'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:687:in `block (2 levels) in default_terminator'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:686:in `catch'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:686:in `block in default_terminator'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:200:in `block in halting'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:595:in `block in invoke_before'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:595:in `each'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:595:in `invoke_before'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.0.6/lib/active_support/callbacks.rb:106:in `run_callbacks'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/good_job-3.15.14/lib/good_job/notifier.rb:192:in `block (2 levels) in listen'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/good_job-3.15.14/lib/good_job/notifier.rb:235:in `with_connection'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/good_job-3.15.14/lib/good_job/notifier.rb:178:in `block in listen'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/safe_task_executor.rb:24:in `block in execute'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:48:in `block in synchronize'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:48:in `synchronize'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:48:in `synchronize'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/safe_task_executor.rb:22:in `execute'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/ivar.rb:170:in `safe_execute'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/scheduled_task.rb:298:in `process_task'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/timer_set.rb:98:in `block in ns_post_task'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:352:in `run_task'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:343:in `block (3 levels) in create_worker'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:334:in `loop'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:334:in `block (2 levels) in create_worker'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:333:in `catch'", "/Users/gap/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/concurrent-ruby-1.2.2/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:333:in `block in create_worker'"]

@bensheldon
Copy link
Owner

@gap777 thanks for opening this issue! I think I see the problem: I'm missing a Rails.application.executor.wrap around that newly introduced GoodJob::Process reference. I'll have a patch momentarily.

@bensheldon
Copy link
Owner

I just released the fix for this. Thank you again! https://github.com/bensheldon/good_job/releases/tag/v3.16.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants