-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace webrick with a small/simple custom rack-compatible http server #1017
Comments
Can I take this? |
@dixpac yes please 🙏 |
And to calibrate the level of polish I'm expecting (low): I have previously fed this into GitHub Copilot and ChatGPT and the result seemed fine. There already is some integration testing, so maybe 1 or 2 more test cases in this pattern should be sufficient: good_job/spec/lib/good_job/probe_server_spec.rb Lines 14 to 30 in 3bc2f85
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would like to drop the runtime dependency on webrick. Webrick is only used for the probe server functionality which is intended to be a private interface.
I think webrick could be replaced with <100 lines of Ruby to implement a bare minimum http server to be used for the probe server, thus it would only need to implement simple GET and string paths, and not do other query-parsing/etc.
The text was updated successfully, but these errors were encountered: