Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential documentation error in GoodJob::ActiveJobExtensions::NotifyOptions #1321

Closed
pgvsalamander opened this issue Apr 12, 2024 · 2 comments
Closed

Potential documentation error in GoodJob::ActiveJobExtensions::NotifyOptions #1321

pgvsalamander opened this issue Apr 12, 2024 · 2 comments

Comments

@pgvsalamander
Copy link
Contributor

The documentation for using the NotifyOptions extension mention including GoodJob::ActiveJobExtensions::Notify in order to make use of those features, but the module defined is GoodJob::ActiveJobExtensions::NotifyOptions. Is that a typo, or is there some magic I'm missing that defines that module elsewhere?

good_job/lib/good_job/active_job_extensions/notify_options.rb

Line 12 in d01b545

# include GoodJob::ActiveJobExtensions::Notify

I'll submit a PR if this is an error.
@bensheldon
Copy link
Owner

Definitely a typo. Thanks!

@pgvsalamander pgvsalamander mentioned this issue Apr 12, 2024
Merged
@pgvsalamander
Copy link
Contributor Author

Created #1322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bensheldon @pgvsalamander