poll-interval=-1 does not disable polling as intended

[bensheldon]

This issue reported by @minimul in #127 (comment).

[bensheldon]

I did some investigation, added a little bit of additional logging and could not reproduce this.

# What polling looks like
bensheldon /Users/bensheldon/Repositories/bensheldon/good_job/spec/test_app (ᛋ main) $ GOOD_JOB_POLL_INTERVAL=1 bundle exec good_job start
[GoodJob] Notifier subscribed with LISTEN
[GoodJob] [86371] GoodJob started scheduler with queues=* max_threads=10 poll_interval=1.
[GoodJob] Ran GoodJob poller
[GoodJob] Ran GoodJob poller
[GoodJob] Ran GoodJob poller
^C[GoodJob] Notifier unsubscribed with UNLISTEN
[GoodJob] [86371] GoodJob shutting down scheduler...
[GoodJob] [86371] GoodJob scheduler is shut down.

# Disabling polling
bensheldon /Users/bensheldon/Repositories/bensheldon/good_job/spec/test_app (ᛋ main) $ GOOD_JOB_POLL_INTERVAL=-1 bundle exec good_job start
[GoodJob] Notifier subscribed with LISTEN
[GoodJob] [86394] GoodJob started scheduler with queues=* max_threads=10 poll_interval=-1.
^C[GoodJob] Notifier unsubscribed with UNLISTEN
[GoodJob] [86394] GoodJob shutting down scheduler...
[GoodJob] [86394] GoodJob scheduler is shut down.

# Disabling polling with quotes
bensheldon /Users/bensheldon/Repositories/bensheldon/good_job/spec/test_app (ᛋ main) $ GOOD_JOB_POLL_INTERVAL="-1" bundle exec good_job start
[GoodJob] Notifier subscribed with LISTEN
[GoodJob] [86457] GoodJob started scheduler with queues=* max_threads=10 poll_interval=-1.
^C[GoodJob] Notifier unsubscribed with UNLISTEN
[GoodJob] [86457] GoodJob shutting down scheduler...
[GoodJob] [86457] GoodJob scheduler is shut down.

[minimul]

I checked and I was on 1.1.3 when I reported this.

I just updated to 1.2.4 and now all is well.

Apologies, I assumed I was on a recent version.

[bensheldon]

@minimul fhew! Glad you were able to update and have this be working as expected ☺️