Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Advisory Lock on ActiveJob job uuid instead of GoodJob's job uuid #272

Closed
bensheldon opened this issue Jun 22, 2021 · 0 comments · Fixed by #336 or #337
Closed

Set Advisory Lock on ActiveJob job uuid instead of GoodJob's job uuid #272

bensheldon opened this issue Jun 22, 2021 · 0 comments · Fixed by #336 or #337

Comments

@bensheldon
Copy link
Owner

GoodJob should lock the ActiveJob job uuid to allow other processes outside of the job runner (e.g. the dashboard) to more safely perform lifecycle operations (destroy, retry, etc).

Idea: Change the locking query to use the ActiveJob uuid, and also do an additional lock on the (deprecated) Goodjob uuid. That will be a performance hit, but make it safer to upgrade.

Idea: Include GoodJob version in Notifier's SET application_name because an upgrade/deprecation challenge is determining which versions of GoodJob clients are currently running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant