Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Frozen String Literal to all files #298

Closed
2 tasks done
bensheldon opened this issue Jul 19, 2021 · 2 comments
Closed
2 tasks done

Add Frozen String Literal to all files #298

bensheldon opened this issue Jul 19, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@bensheldon
Copy link
Owner

bensheldon commented Jul 19, 2021 •
edited
Loading

Something overlooked in the initial project set up.

  • Update Rubocop to remove disabling of Style/FrozenStringLiteralComment rule (not sure why that was initially there; probably merely copy-pasta from some other project)
  • Run Rubocop to add the literal to all the files
@bensheldon bensheldon added the good first issue Good for newcomers label Jul 19, 2021
@tedt10e
Copy link
Contributor

tedt10e commented Jul 20, 2021 •
edited
Loading

Hello @bensheldon
PR Submitted @ #302

@tedt10e tedt10e mentioned this issue Jul 20, 2021
Merged
@bensheldon
Copy link
Owner Author

@tedhexaflow Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bensheldon @tedt10e